Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fragment doc with Codegen Client Preset support #12290

Merged

Conversation

eddeee888
Copy link
Contributor

This PR updates Apollo fragment masking support doc for Codegen Client Preset.

Related PR with fixes and recommended codegen config to make it work: dotansimha/graphql-code-generator#10268

@apollo-cla
Copy link

@eddeee888: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: 08d9cd7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 22, 2025

👷 Deploy request for apollo-client-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 08d9cd7

@svc-apollo-docs
Copy link

svc-apollo-docs commented Jan 22, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* (developer-tools)/react/(latest)/data/fragments.mdx

Build ID: ccf5b505a940b6b51d8eb00f

URL: https://www.apollographql.com/docs/deploy-preview/ccf5b505a940b6b51d8eb00f

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll preapprove it for now. This change looks good. Will get it merged after that version has been released. Thanks so much!

@eddeee888 eddeee888 marked this pull request as ready for review January 28, 2025 12:10
@eddeee888 eddeee888 requested a review from a team as a code owner January 28, 2025 12:10
@jerelmiller jerelmiller merged commit 45120e8 into apollographql:main Jan 28, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants