Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tagged/branded primitive types when used with Unmasked #12270

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

jerelmiller
Copy link
Member

@jerelmiller jerelmiller commented Jan 14, 2025

Related to #12266

Ensures branded primitive types when used as scalars with the Unmasked type.

@jerelmiller jerelmiller requested a review from phryneas January 14, 2025 17:27
Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: 60833a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svc-apollo-docs
Copy link

svc-apollo-docs commented Jan 14, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: be3bfbab859e1ec8c64bb264

@jerelmiller jerelmiller linked an issue Jan 14, 2025 that may be closed by this pull request
Copy link

pkg-pr-new bot commented Jan 14, 2025

npm i https://pkg.pr.new/@apollo/client@12270

commit: 60833a1

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 60833a1
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/6786a07b9ea3fa0008c3d707
😎 Deploy Preview https://deploy-preview-12270--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 14, 2025

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 40.66 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 50.07 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 47.18 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 36.18 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 33.58 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.29 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.7 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.78 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.84 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.42 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.41 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.35 KB (0%)
import { useFragment } from "dist/react/index.js" 2.36 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.31 KB (0%)

@jerelmiller
Copy link
Member Author

This is the solution proposed in #12267 (comment) which was blessed as a solution. Going to go ahead and get this merged so we can get this fix out.

@jerelmiller jerelmiller merged commit 3601246 into main Jan 14, 2025
46 checks passed
@jerelmiller jerelmiller deleted the jerel/handle-tagged-primitives branch January 14, 2025 17:41
@github-actions github-actions bot mentioned this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unmasked breaks when using Tagged type
2 participants