Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor @nonreactive with useFragment and cache.watchFragment #11844

Merged
merged 9 commits into from
May 14, 2024
Merged

Honor @nonreactive with useFragment and cache.watchFragment #11844

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d7e96a0
Add failing test for useFragment with @nonreactive
jerelmiller May 13, 2024
cd4e3b7
Add failing test for nonreactive with nested fragment
jerelmiller May 13, 2024
ed96057
Enable test in ApolloClient for watchFragment with nonreactive
jerelmiller May 13, 2024
d303f51
Compare results in fragment with equalByQuery helper to support nonre…
jerelmiller May 13, 2024
e387903
Always deliver the first result by checking if latestDiff is set
jerelmiller May 13, 2024
10d88be
Minor refactor to reuse value
jerelmiller May 13, 2024
11d577b
Add changeset
jerelmiller May 13, 2024
4932af3
Remove outdated comment
jerelmiller May 13, 2024
abdc874
Swap order of args
jerelmiller May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor refactor to reuse value
  • Loading branch information
@jerelmiller
jerelmiller committed May 13, 2024
commit 10d88be5b3cfc661b61214d906c4234bc5814097
6 changes: 2 additions & 4 deletions src/cache/core/cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,23 +229,21 @@ export abstract class ApolloCache<TSerialized> implements DataProxy {
options: WatchFragmentOptions<TData, TVars>
): Observable<WatchFragmentResult<TData>> {
const { fragment, fragmentName, from, optimistic = true } = options;
const query = this.getFragmentDoc(fragment, fragmentName);

const diffOptions: Cache.DiffOptions<TData, TVars> = {
returnPartialData: true,
id: typeof from === "string" ? from : this.identify(from),
query: this.getFragmentDoc(fragment, fragmentName),
query,
optimistic,
};

let latestDiff: DataProxy.DiffResult<TData> | undefined;

return new Observable((observer) => {
const query = this.getFragmentDoc(fragment, fragmentName);

return this.watch<TData, TVars>({
...diffOptions,
immediate: true,
query,
callback(diff) {
if (
// Always ensure we deliver the first result
Expand Down