-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make useRenderGuard
more resilient to changes in React internals.
#11659
Conversation
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
🦋 Changeset detectedLatest commit: f042fff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that deleting a character resulted in a 2 byte increase 🤔. Thanks for putting this together though!
Since we don't know what exactly might be change with React 19, this change makes our
useRenderGuard
slightly more resilient, and if it breaks, it does so in a less interrupting way (always returnfalse
instead of alwaystrue
).It should also save one byte of bundle size ;)But then it gzips 2 bytes bigger 🤦