-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add react/internal
entry point and update existing imports
#11439
Conversation
🦋 Changeset detectedLatest commit: 3acbf58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
@@ -1,4 +1,4 @@ | |||
{ | |||
"dist/apollo-client.min.cjs": 39137, | |||
"import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 32653 | |||
"dist/apollo-client.min.cjs": 39184, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting the minified files next to each other, there is literally no difference in them apart from the version number - I think this might have been a tad off in the upstream branch or something.
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
We are now getting the deduplication of the cache internals as expected: https://github.com/apollographql/apollo-client/actions/runs/7257554913 |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/release:pr |
A new release has been made for this PR. You can install it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, let's get this in! 🚀
This is a reimplementation of #11426 with the latest changes from
release-3.9
.We had some bundling issues that caused some of the internals of the
react/cache
folder to be duplicated in the bundle. This was due to the fact thatreact/hooks
is its own entry point, and the newcreateQueryPreloader
function that was introduced also pulled in these dependencies outside thereact/hooks
folder.Checklist: