-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove retain
call from useBackgroundQuery
to allow for auto disposal
#11438
Conversation
🦋 Changeset detectedLatest commit: 163047a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see one more test, but generally approved :)
|
||
await expect(Profiler).not.toRerender(); | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add one more test with a "natural dispose after being mounted with useReadQuery
"
useBackgroundQuery
-> mount useReadQuery
-> unmount useReadQuery
-> make sure it's disposed -> mount useReadQuery
-> make sure it resubscribes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! e9165f1
…pose works correctly
0a2275b
to
55871c5
Compare
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks to the work in #11412, we no longer need to
retain
thequeryRef
produced byuseBackgroundQuery
since this is handled inuseReadQuery
for us. This means that aqueryRef
not consumed byuseReadQuery
within the givenautoDisposeTimeoutMs
will now be auto disposed, removing the need for the query to hang out as active while not used. #11412 enabled the ability to auto resubscribe to a disposedqueryRef
, so when thequeryRef
is consumed after it has been disposed, it will automatically resubscribe.Checklist: