Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useSuspenseQuery: remove promiseCache #11363

Merged
merged 12 commits into from
Dec 1, 2023
Merged

useSuspenseQuery: remove promiseCache #11363

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8ecd36f
`useSuspenseQuery`: remove `promiseCache`
phryneas Nov 15, 2023
b8c51af
missed cleanup
phryneas Nov 15, 2023
532505a
update `current[0]` correctly
phryneas Nov 16, 2023
50c2149
change `key` to empty object
phryneas Nov 16, 2023
b49ddeb
Merge branch 'release-3.9' into pr/remove-useSuspenseQuery-promiseCache
jerelmiller Nov 30, 2023
152baac
Update src/react/hooks/useSuspenseQuery.ts
phryneas Nov 30, 2023
b7931f2
Merge branch 'release-3.9' into pr/remove-useSuspenseQuery-promiseCache
jerelmiller Dec 1, 2023
3ff58fb
Clean up Prettier, Size-limit, and Api-Extractor
jerelmiller Dec 1, 2023
4665fd4
review feedback
phryneas Dec 1, 2023
92d91d1
size-limit
phryneas Dec 1, 2023
a7ad917
Merge branch 'release-3.9' into pr/remove-useSuspenseQuery-promiseCache
phryneas Dec 1, 2023
3f5b734
Clean up Prettier, Size-limit, and Api-Extractor
phryneas Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review feedback
  • Loading branch information
@phryneas
phryneas committed Dec 1, 2023
commit 4665fd421386f8aad7feb7ff73f2deb69547591f
3 changes: 1 addition & 2 deletions src/react/cache/QueryReference.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
createFulfilledPromise,
createRejectedPromise,
} from "../../utilities/index.js";
import type { CacheKey, QueryKey } from "./types.js";
import type { QueryKey } from "./types.js";
import type { useBackgroundQuery, useReadQuery } from "../hooks/index.js";

type Listener<TData> = (promise: Promise<ApolloQueryResult<TData>>) => void;
Expand All @@ -32,7 +32,6 @@ export interface QueryReference<TData = unknown> {
}

interface InternalQueryReferenceOptions {
key: CacheKey;
onDispose?: () => void;
autoDisposeTimeoutMs?: number;
}
Expand Down
1 change: 0 additions & 1 deletion src/react/cache/SuspenseCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ export class SuspenseCache {

if (!ref.current) {
ref.current = new InternalQueryReference(createObservable(), {
key: cacheKey,
autoDisposeTimeoutMs: this.options.autoDisposeTimeoutMs,
onDispose: () => {
delete ref.current;
Expand Down