-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce export type
for all type-level exports.
#11115
Conversation
🦋 Changeset detectedLatest commit: ce6e69f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My review is mostly a plea to keep formatting where it was before, just with the types/values separated. Thanks for getting this updated!
Oh my god @jerelmiller, next time just tell me "dude, format that!", please don't put that much work in! 🤣 Totally my fault - I had kinda anticipated that those would autoformat anyways after #11111, but thinking about it, that would only happen to those inside the |
Co-authored-by: Jerel Miller <[email protected]>
eb9f2ce
to
eee426e
Compare
Checklist:
This was triggered by my review over in #11112 - seems we were only enforcing that for
import
statements, but not forexport
statements.