Make private fields protected in QueryManager

[alessbell]

This PR makes all private fields/methods on the QueryManager class protected, making them accessible to any class that extends QueryManager while remaining inaccessible externally.

The main benefit for our purposes is being able to access type information in the NextSSRApolloClient class which (unsafely) accesses QueryManager methods.

Without going so far as to make these fields public, protected seems like a reasonable middle ground so we can still benefit from TS types in this scenario.

Before

After

Note the number annotation in the D.TS output for foo:

Checklist:

• If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
• If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests

[changeset-bot]

🦋 Changeset detected

Latest commit: c22ab96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	36.84 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	43.38 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	32.56 KB (0%)
import { ApolloProvider } from "dist/react/index.js"	1.3 KB (0%)
import { useQuery } from "dist/react/index.js"	4.33 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	4.65 KB (0%)
import { useMutation } from "dist/react/index.js"	2.56 KB (0%)
import { useSubscription } from "dist/react/index.js"	2.31 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	3.71 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	3.78 KB (0%)
import { useReadQuery } from "dist/react/index.js"	2.48 KB (0%)
import { useFragment } from "dist/react/index.js"	2.12 KB (0%)

[jerelmiller]

Could we only move over the members that are accessed by NextSSRApolloClient? There is still a lot of QueryManager that will only ever need to be private, so I'd love to keep those that way as much as possible.

[alessbell]

@jerelmiller sure, that works too - updated 👍

[jerelmiller]

I really need to fix my editor so that it removes trailing whitespace 🤦‍♂️

[phryneas]

Prettier will take care of that soon :)

[jerelmiller]

Appreciate you scoping this down! LGTM

[phryneas]

I'm gonna merge this since Alessia is OOO, and there's no good reason to let this sit around any longer :)