Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix @defer with payload containing "---" #10891

Merged
merged 3 commits into from
May 18, 2023
Merged

Fix @defer with payload containing "---" #10891

merged 3 commits into from
May 18, 2023

Conversation

laverdet
Copy link
Contributor

When using @defer if the response payload contains "---" then the query will fail with an error message such as:

	ApolloError: Unterminated string in JSON at position 15378

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@laverdet
Fix @defer with payload containing "---"
6a54a5e 
When using `@defer` if the response payload contains "---" then the
query will fail with an error message such as:

		ApolloError: Unterminated string in JSON at position 15378
@netlify
Copy link

netlify bot commented May 18, 2023 •
edited
Loading

👷 Deploy request for apollo-client-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 76f2814

@changeset-bot
Copy link

changeset-bot bot commented May 18, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 76f2814

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@laverdet
Copy link
Contributor Author

Re: @alessbell

alessbell added 2 commits May 18, 2023 14:42
@alessbell
chore(tests): updates HttpLink test to validate that boundaries
a635f22 
are not parsed within response data, only read at the beginning
of each chunk.
@alessbell
chore: update changeset
76f2814
alessbell
alessbell approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thanks for the PR, @laverdet! Updated a test case to prevent regressions, this fix LGTM 🚀

src/link/http/parseAndCheckHttpResponse.ts
"Unsupported patch content type: application/json is required."
);
}
// nb: Technically you'd want to slice off the beginning "\r\n" but since
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alessbell alessbell merged commit ab42a5c into apollographql:main May 18, 2023
This was referenced May 18, 2023
Merged
Merged
alessbell added a commit that referenced this pull request Jun 12, 2023
@alessbell
[Do not merge]
030bcf5 
Temporarily revert "Fix `@defer` with payload containing "---"
(#10891)" to unblock testing until upstream router fix is in
place.

This reverts commit ab42a5c.
@alessbell alessbell mentioned this pull request Jun 12, 2023
Closed
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alessbell alessbell alessbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laverdet @alessbell