InMemoryCache.gc: also trigger FragmentRegistry.resetCaches (#11355)

apollographql · Nov 14, 2023 · 7d8e184 · 7d8e184
1 parent b0bf0d8
commit 7d8e184
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 2 deletions.
diff --git a/.api-reports/api-report-cache.md b/.api-reports/api-report-cache.md
@@ -488,6 +488,8 @@ export interface FragmentRegistryAPI {
     // (undocumented)
     register(...fragments: DocumentNode[]): this;
     // (undocumented)
+    resetCaches(): void;
+    // (undocumented)
     transform<D extends DocumentNode>(document: D): D;
 }
 

diff --git a/.api-reports/api-report-core.md b/.api-reports/api-report-core.md
@@ -885,6 +885,8 @@ interface FragmentRegistryAPI {
     // (undocumented)
     register(...fragments: DocumentNode[]): this;
     // (undocumented)
+    resetCaches(): void;
+    // (undocumented)
     transform<D extends DocumentNode>(document: D): D;
 }
 

diff --git a/.api-reports/api-report-utilities.md b/.api-reports/api-report-utilities.md
@@ -1028,6 +1028,8 @@ interface FragmentRegistryAPI {
     // (undocumented)
     register(...fragments: DocumentNode[]): this;
     // (undocumented)
+    resetCaches(): void;
+    // (undocumented)
     transform<D extends DocumentNode>(document: D): D;
 }
 

diff --git a/.api-reports/api-report.md b/.api-reports/api-report.md
@@ -1057,6 +1057,8 @@ interface FragmentRegistryAPI {
     // (undocumented)
     register(...fragments: DocumentNode[]): this;
     // (undocumented)
+    resetCaches(): void;
+    // (undocumented)
     transform<D extends DocumentNode>(document: D): D;
 }
 

diff --git a/.changeset/violet-lions-draw.md b/.changeset/violet-lions-draw.md
@@ -0,0 +1,5 @@
+---
+"@apollo/client": patch
+---
+
+InMemoryCache.gc now also triggers FragmentRegistry.resetCaches (if there is a FragmentRegistry)
diff --git a/.size-limit.cjs b/.size-limit.cjs
@@ -1,7 +1,7 @@
 const checks = [
   {
     path: "dist/apollo-client.min.cjs",
-    limit: "38142",
+    limit: "38164",
   },
   {
     path: "dist/main.cjs",
@@ -10,7 +10,7 @@ const checks = [
   {
     path: "dist/index.js",
     import: "{ ApolloClient, InMemoryCache, HttpLink }",
-    limit: "32167",
+    limit: "32188",
   },
   ...[
     "ApolloProvider",

diff --git a/src/cache/inmemory/fragmentRegistry.ts b/src/cache/inmemory/fragmentRegistry.ts
@@ -16,6 +16,7 @@ export interface FragmentRegistryAPI {
   register(...fragments: DocumentNode[]): this;
   lookup(fragmentName: string): FragmentDefinitionNode | null;
   transform<D extends DocumentNode>(document: D): D;
+  resetCaches(): void;
 }
 
 // As long as createFragmentRegistry is not imported or used, the

diff --git a/src/cache/inmemory/inMemoryCache.ts b/src/cache/inmemory/inMemoryCache.ts
@@ -296,6 +296,7 @@ export class InMemoryCache extends ApolloCache<NormalizedCacheObject> {
     canonicalStringify.reset();
     print.reset();
     this.addTypenameTransform.resetCache();
+    this.config.fragments?.resetCaches();
     const ids = this.optimisticData.gc();
     if (options && !this.txCount) {
       if (options.resetResultCache) {