-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #6656 from apollographql/revamp-commonjs-interdepe…
…ndencies Rework interdependencies between @apollo/client/* entry points.
- Loading branch information
Showing
151 changed files
with
1,564 additions
and
975 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| const entryPoints = [ | ||
| { dirs: [], bundleName: "main" }, | ||
| { dirs: ['cache'] }, | ||
| { dirs: ['core'] }, | ||
| { dirs: ['errors'] }, | ||
| { dirs: ['link', 'batch'] }, | ||
| { dirs: ['link', 'batch-http'] }, | ||
| { dirs: ['link', 'context'] }, | ||
| { dirs: ['link', 'core'] }, | ||
| { dirs: ['link', 'error'] }, | ||
| { dirs: ['link', 'http'] }, | ||
| { dirs: ['link', 'retry'] }, | ||
| { dirs: ['link', 'schema'] }, | ||
| { dirs: ['link', 'utils'] }, | ||
| { dirs: ['link', 'ws'] }, | ||
| { dirs: ['react'] }, | ||
| { dirs: ['react', 'components'] }, | ||
| { dirs: ['react', 'context'] }, | ||
| { dirs: ['react', 'data'] }, | ||
| { dirs: ['react', 'hoc'] }, | ||
| { dirs: ['react', 'hooks'] }, | ||
| { dirs: ['react', 'parser'] }, | ||
| { dirs: ['react', 'ssr'] }, | ||
| { dirs: ['utilities'] }, | ||
| { dirs: ['testing'], extensions: [".js", ".jsx"] }, | ||
| ]; | ||
|
|
||
| const lookupTrie = Object.create(null); | ||
| entryPoints.forEach(info => { | ||
| let node = lookupTrie; | ||
| info.dirs.forEach(dir => { | ||
| const dirs = node.dirs || (node.dirs = Object.create(null)); | ||
| node = dirs[dir] || (dirs[dir] = { isEntry: false }); | ||
| }); | ||
| node.isEntry = true; | ||
| }); | ||
|
|
||
| exports.forEach = function(callback, context) { | ||
| entryPoints.forEach(callback, context); | ||
| }; | ||
|
|
||
| exports.map = function map(callback, context) { | ||
| return entryPoints.map(callback, context); | ||
| }; | ||
|
|
||
| const path = require("path").posix; | ||
|
|
||
| exports.check = function (id, parentId) { | ||
| const resolved = path.resolve(path.dirname(parentId), id); | ||
| const importedParts = partsAfterDist(resolved); | ||
|
|
||
| if (importedParts) { | ||
| const entryPointIndex = lengthOfLongestEntryPoint(importedParts); | ||
| if (entryPointIndex === importedParts.length) { | ||
| return true; | ||
| } | ||
|
|
||
| if (entryPointIndex >= 0) { | ||
| const parentParts = partsAfterDist(parentId); | ||
| const parentEntryPointIndex = lengthOfLongestEntryPoint(parentParts); | ||
| const sameEntryPoint = | ||
| entryPointIndex === parentEntryPointIndex && | ||
| arraysEqualUpTo(importedParts, parentParts, entryPointIndex); | ||
|
|
||
| // If the imported ID and the parent ID have the same longest entry | ||
| // point prefix, then this import is safely confined within that | ||
| // entry point. Returning false lets Rollup know this import is not | ||
| // external, and can be bundled into the CJS bundle that we build | ||
| // for this shared entry point. | ||
| if (sameEntryPoint) { | ||
| return false; | ||
| } | ||
|
|
||
| console.warn(`Risky cross-entry-point nested import of ${id} in ${ | ||
| partsAfterDist(parentId).join("/") | ||
| }`); | ||
| } | ||
| } | ||
|
|
||
| return false; | ||
| }; | ||
|
|
||
| function partsAfterDist(id) { | ||
| const parts = id.split(path.sep); | ||
| const distIndex = parts.lastIndexOf("dist"); | ||
| if (distIndex >= 0) { | ||
| return parts.slice(distIndex + 1); | ||
| } | ||
| } | ||
|
|
||
| function lengthOfLongestEntryPoint(parts) { | ||
| let node = lookupTrie; | ||
| let longest = -1; | ||
| for (let i = 0; node && i < parts.length; ++i) { | ||
| if (node.isEntry) longest = i; | ||
| node = node.dirs && node.dirs[parts[i]]; | ||
| } | ||
| if (node && node.isEntry) { | ||
| return parts.length; | ||
| } | ||
| return longest; | ||
| } | ||
|
|
||
| function arraysEqualUpTo(a, b, end) { | ||
| for (let i = 0; i < end; ++i) { | ||
| if (a[i] !== b[i]) return false; | ||
| } | ||
| return true; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.