Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created find_motifs_iter to iterate over results #17

Merged
merged 5 commits into from
May 4, 2021

Conversation

Raphtor
Copy link
Contributor

@Raphtor Raphtor commented Apr 28, 2021

Maintained find_motifs for backward compatibility.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2021

Codecov Report

Merging #17 (d1d8770) into master (7ee70db) will increase coverage by 0.41%.
The diff coverage is 87.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   86.63%   87.05%   +0.41%     
==========================================
  Files           4        4              
  Lines         419      448      +29     
==========================================
+ Hits          363      390      +27     
- Misses         56       58       +2     
Impacted Files Coverage Δ
grandiso/__init__.py 85.71% <75.00%> (-0.62%) ⬇️
grandiso/test_grandiso.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee70db...d1d8770. Read the comment docs.

@j6k4m8
Copy link
Member

j6k4m8 commented May 1, 2021

This is awesome, and it's going to get us a huge performance bump in a few current bottlenecks!

I pushed two commits to the tail end which:

  • Add type annotations for the generator
  • Add some basic tests for the find_motifs_iter call
  • Add this update (with credit! woo) to the changelog

Take a look and make sure I made everything in the spirit of your PR, and then let's merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants