Check whether message has a line before posting to GitLab

Fixes prontolabs#125

CHANGELOG.md

@@ -8,6 +8,7 @@
 
 ### Bugs fixed
 
+* [#125](https://github.com/mmozuras/pronto/issues/125): check whether message has a line before posting to GitLab.
 * Post on commit comments on correct commit: use message.commit_sha to set comment.sha instead of head.
 * [#201](https://github.com/mmozuras/pronto/issues/201): allow messages without line positions or paths.
 

lib/pronto/formatter/bitbucket_formatter.rb

@@ -10,7 +10,7 @@ def pretty_name
       end
 
       def line_number(message, _)
-        message.line.new_lineno
+        message.line.new_lineno if message.line
       end
     end
   end

lib/pronto/formatter/bitbucket_pull_request_formatter.rb

@@ -8,6 +8,10 @@ def client_module
       def pretty_name
         'BitBucket'
       end
+
+      def line_number(message, _)
+        message.line.line.new_lineno if message.line
+      end
     end
   end
 end

lib/pronto/formatter/commit_formatter.rb

@@ -7,10 +7,6 @@ def existing_comments(messages, client, repo)
         grouped_comments(comments)
       end
 
-      def line_number(message, _)
-        message.line.new_lineno
-      end
-
       def submit_comments(client, comments)
         comments.each { |comment| client.create_commit_comment(comment) }
       rescue Octokit::UnprocessableEntity, HTTParty::Error => e

lib/pronto/formatter/gitlab_formatter.rb

@@ -10,7 +10,7 @@ def pretty_name
       end
 
       def line_number(message, _)
-        message.line.commit_line.new_lineno
+        message.line.commit_line.new_lineno if message.line
       end
     end
   end

lib/pronto/formatter/pull_request_formatter.rb

@@ -7,10 +7,6 @@ def existing_comments(messages, client, repo)
         grouped_comments(comments)
       end
 
-      def line_number(message, _)
-        message.line.line.new_lineno
-      end
-
       def submit_comments(client, comments)
         comments.each { |comment| client.create_pull_comment(comment) }
       rescue Octokit::UnprocessableEntity, HTTParty::Error => e