middleware chain is broken when found ctx.output #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure about this - I need your eyes here.
If I'm on target - I'll add tests so you can merge.
I'm using restify, and I have other mw on the chain after the swagger_router.
(e.g `server.on('after', restify.auditLogger(options.auditLogCfg));` )
I first noted that when I dont use json_error_handler - I get the audit entry on requests that error, and when I do - I dont.
(e.g. - the 'after' event is not emitted)
The research led me to the corrected lines.
|
Scott - please take a look here... Let me know what you think |
|
I think you're right. I believe the assumption was that this was the terminator on the chain. But even so, I don't believe the appropriate thing is to skip the next() call. |
|
that's great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about this - I need your eyes here.
If I'm on target - I'll add tests so you can merge.
.
I'm using restify, and I have other mw on the chain after the swagger_router.
(e.g
server.on('after', restify.auditLogger(options.auditLogCfg));)I first noted that when I dont use
json_error_handler- I get the audit entry on requests that error, and when I do - I dont get the desired log entries.(e.g. - the 'after' event is not emitted - that suggests that the mw chain is broken)
Then I noted that they are emitted with
defaultErrorHandlerand are not emitted withjson_error_handlerbecause it createsctx.output, wheredefaultErrorHandlerdoes not.The research led me to the corrected lines.
Let me know what you think.