Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript refactoring [WIP] #24

Closed
wants to merge 3 commits into from
Closed

Typescript refactoring [WIP] #24

wants to merge 3 commits into from

Conversation

pocesar
Copy link
Contributor

@pocesar pocesar commented Mar 15, 2021 •
edited
Loading

DONE:

  • Entire src converted to strict Typescript
  • Re-exported all internal types
  • Type-safe Playwright depending on the browser chosen (Chrome, Firefox, Webkit)
  • Build sitemaps and declaration sitemaps
  • Fix tests for Typescript

TODO:

  • Integrating nicely with the Apify SDK, too many documentation and types problems with generics when generating the docs
  • Configure API Extractor properly No support for import("something").SomeType
  • Review some changes on Puppeteer 7+ types
  • Puppeteer support for browser other than Chrome
  • Check if changes to code itself are correct, like using optional parameters or destructuring options that are optional

closes #21

@pocesar pocesar mentioned this pull request Apr 28, 2021
Merged
vladfrangu added a commit to vladfrangu/browser-pool that referenced this pull request Aug 3, 2021
@vladfrangu
feat: make LaunchContext's options generic
a208397 
Needed for apify#24
mnmkng pushed a commit that referenced this pull request Aug 3, 2021
@vladfrangu
refactor: convert launch context to TS (#34)
6cc4f11 
* refactor: convert launch contex to TS

* chore: rerun CI

* feat: make LaunchContext's options generic
Needed for #24
@vladfrangu
Copy link
Member

Closing this as it's been handled through PRs: #30 #31 #34 #35 #36 #37 #38 and #39

@vladfrangu vladfrangu closed this Aug 13, 2021
@mnmkng mnmkng deleted the refactor/ts branch August 13, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSDoc + TS build for the types
2 participants
@pocesar @vladfrangu