Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for CriteriaBuilder #458

Closed
wants to merge 11 commits into from

Conversation

clebrsonn
Copy link

@clebrsonn clebrsonn commented Jul 22, 2023

added criteriabuilder, junction predicate and predicate for create conditions in where and return in string


This change is Reviewable

@clebrsonn clebrsonn changed the title Suggestion for CriteriaBuilder WIP: Suggestion for CriteriaBuilder Jul 23, 2023
@stohn777
Copy link
Contributor

Interestingly following. Unit tests?

@clebrsonn
Copy link
Author

Interestingly following. Unit tests?

I'm finishing unit tests. Do you have some ideas for scenario?

@stohn777
Copy link
Contributor

stohn777 commented Jul 23, 2023

I'm finishing unit tests. Do you have some ideas for scenario?

fflib_CriteriaBuilderTest class focusing on the output of the toSoql() method. Many variations of the Where clause to cover.

@stohn777
Copy link
Contributor

As I'm sure you know, this SF Developer topic is likely the canonical reference for the Where-Clause specs.

[1] https://developer.salesforce.com/docs/atlas.en-us.soql_sosl.meta/soql_sosl/sforce_api_calls_soql_select_conditionexpression.htm

@clebrsonn
Copy link
Author

As I'm sure you know, this SF Developer topic is likely the canonical reference for the Where-Clause specs.

[1] https://developer.salesforce.com/docs/atlas.en-us.soql_sosl.meta/soql_sosl/sforce_api_calls_soql_select_conditionexpression.htm

Thanks, I'll verify.

cleberson.chagas added 2 commits July 24, 2023 01:48
@clebrsonn
Copy link
Author

clebrsonn commented Jul 24, 2023

@stohn777 I finished the adjustments for the most common cases of where conditions.
I based on hibernate and the two open PR's below:

393, 313

@clebrsonn clebrsonn changed the title WIP: Suggestion for CriteriaBuilder Suggestion for CriteriaBuilder Jul 24, 2023
@daveespo
Copy link
Contributor

See #483

@daveespo daveespo closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants