Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit hooks #345

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Update pre-commit hooks #345

merged 1 commit into from
Jul 4, 2024

Conversation

tofu-rocketry
Copy link
Member

Resolves #344

Set pre-commit-hooks to last Py 3.6 compatible version and add a couple of extra checks.

@tofu-rocketry tofu-rocketry added this to the 3.4.1 milestone Jul 3, 2024
@tofu-rocketry tofu-rocketry self-assigned this Jul 3, 2024
@tofu-rocketry tofu-rocketry requested a review from a team as a code owner July 3, 2024 08:42
@tofu-rocketry tofu-rocketry mentioned this pull request Jul 3, 2024
Closed
@tofu-rocketry
Update pre-commit hooks
f816aea 
Set pre-commit-hooks to last Py 3.6 compatible version and add a couple
of extra checks.
gregcorbett
gregcorbett approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me :)

@tofu-rocketry tofu-rocketry merged commit 55e1400 into apel:dev Jul 4, 2024
9 of 10 checks passed
@tofu-rocketry tofu-rocketry deleted the pre-commit-update branch July 4, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregcorbett gregcorbett gregcorbett approved these changes

Assignees

@tofu-rocketry tofu-rocketry

Labels
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.

Update pre-commit to use add more checks (that are only available in Py 3)
2 participants
@tofu-rocketry @gregcorbett