setup.py to build and install the package underneath #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sae126V
changed the title
tofu-rocketry
force-pushed
the
handle-separate-build-and-install-phase
branch
from
a313d2b to
3d48d76
Compare
tofu-rocketry
approved these changes
May 10, 2024
tofu-rocketry
requested changes
May 10, 2024
tofu-rocketry
requested changes
May 21, 2024
Now, `setup.py` will make use of the build step to install the package. Enabling separate flows for the build and install phases if specified. We are currently NOT supporting a few standard commands that are out of scope or NOT being asked, listed below: - `register`, `bdist_rpm`, `bdist_wininst`, `upload`. Also, We do NOT support extra commands with the setup.py except a few commands like `develop`, `egg_info`, and `bdist_egg`.
Sae126V
force-pushed
the
handle-separate-build-and-install-phase
branch
from
17bbfa8 to
659373d
Compare
tofu-rocketry
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #296
Resolves GT-331
Now will make use of build step to install the package and enabling separate flows for build and install phases. It also now supports basic commands for setup in [cf905c5].