Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rpmlint to perform rpm checks in given location #325

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Fix rpmlint to perform rpm checks in given location #325

merged 2 commits into from
Apr 23, 2024

Conversation

Sae126V
Copy link
Member

@Sae126V Sae126V commented Apr 19, 2024

7952bc5

This commit will allow to run the file in home directory and perform rpmlint checks in an given pwd location(Say, when running the FPM script with -s and -b).

@Sae126V Sae126V requested a review from a team as a code owner April 19, 2024 09:18
@Sae126V Sae126V changed the title Update to fix rpmlint to perform rpm checks in given location Fix rpmlint to perform rpm checks in given location Apr 19, 2024
@tofu-rocketry tofu-rocketry self-assigned this Apr 23, 2024
tofu-rocketry
tofu-rocketry requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@tofu-rocketry tofu-rocketry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, though see inline comment, and please improve the commit message. You can add the text from the PR description as the body text to the commit message (the summary line is ok).

@tofu-rocketry tofu-rocketry added this to the 3.4.1 milestone Apr 23, 2024
@Sae126V Sae126V force-pushed the Minor-fix-to-SSM-build-script branch 2 times, most recently from 6543f4e to a0718d8 Compare April 23, 2024 09:47
@Sae126V Sae126V requested a review from tofu-rocketry April 23, 2024 09:48
tofu-rocketry
tofu-rocketry requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@tofu-rocketry tofu-rocketry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tweaks. Can you sort the Codacy issues out, please?

@Sae126V Sae126V requested a review from tofu-rocketry April 23, 2024 10:59
“Sae126V” added 2 commits April 23, 2024 13:02
@tofu-rocketry
Update to fix rpmlint to perform rpm checks in given location
606904b 
- This will allow to run the file in home directory and perform rpmlint checks in an given pwd location(Say, when running the FPM script with -s and -b).
@tofu-rocketry
Add quotes to the variable to prevent word splitting
c4de9ff
@tofu-rocketry tofu-rocketry force-pushed the Minor-fix-to-SSM-build-script branch from 24c28f0 to c4de9ff Compare April 23, 2024 12:02
@tofu-rocketry tofu-rocketry merged commit 301c0c8 into apel:dev Apr 23, 2024
7 of 8 checks passed
@Sae126V Sae126V deleted the Minor-fix-to-SSM-build-script branch April 26, 2024 15:34
William-Brown5515 pushed a commit to William-Brown5515/ssm that referenced this pull request Nov 20, 2024
@tofu-rocketry
Merge pull request apel#325 from RedProkofiev/nick-test-hashing
b606026 
Fix to test function not being called on test script running.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tofu-rocketry tofu-rocketry tofu-rocketry approved these changes

Assignees

@tofu-rocketry tofu-rocketry

Labels
enhancement
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Sae126V @tofu-rocketry