Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deb packages for python3 #324

Merged

Conversation

Sae126V
Copy link
Member

@Sae126V Sae126V commented Apr 18, 2024

Related Issue tracking number: 166117

[25eb5c8] :

  • Changed python-pip3 because issue with availability to python3-pip which depends on python3 (>= 3.4~)
  • Changed python-stomp because this lib has a restriction python(<< 2.8) to python3-stomp which depends on python3 (>= 3.3.2-2~)
  • Changed python-ldap because this lib has a restriction python(<< 2.8) to python3-ldap which depends on python3 (>= 3.3.2-2~)

@Sae126V Sae126V requested a review from a team as a code owner April 18, 2024 09:18
Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tofu-rocketry tofu-rocketry self-assigned this Apr 23, 2024
@tofu-rocketry tofu-rocketry added the GGUS Has a related GGUS ticket label Apr 23, 2024
@tofu-rocketry tofu-rocketry added this to the 3.4.1 milestone Apr 23, 2024
@tofu-rocketry tofu-rocketry added bug dependencies Pull requests that update a dependency file labels Apr 23, 2024
Copy link
Member

@tofu-rocketry tofu-rocketry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put the bullet points from the PR into the commit message after the intro line, please? The "why?" is the most important part to record in the commit message.

To clarify, the format should be:

[short summary line]
[blank line]
[body of message, either a paragraph or bullet points that explains why things have changed]

- Changed python-pip3 because issue with availability to python3-pip which depends on python3 (>= 3.4~)
- Changed python-stomp because this lib has a restriction python(<< 2.8) to python3-stomp which depends on python3 (>= 3.3.2-2~)
- Changed python-ldap because this lib has a restriction python(<< 2.8) to python3-ldap which depends on python3 (>= 3.3.2-2~)
@Sae126V Sae126V force-pushed the Issue-with-deb-build-in-FPM-script-for-python3 branch from 25eb5c8 to dfd96e9 Compare April 23, 2024 09:50
@Sae126V Sae126V requested a review from tofu-rocketry April 23, 2024 09:50
Copy link
Member

@tofu-rocketry tofu-rocketry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

@tofu-rocketry tofu-rocketry merged commit b58cc36 into apel:dev Apr 23, 2024
6 of 8 checks passed
@Sae126V Sae126V deleted the Issue-with-deb-build-in-FPM-script-for-python3 branch April 26, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file GGUS Has a related GGUS ticket
Development

Successfully merging this pull request may close these issues.

3 participants