-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deb packages for python3 #324
Fix deb packages for python3 #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put the bullet points from the PR into the commit message after the intro line, please? The "why?" is the most important part to record in the commit message.
To clarify, the format should be:
[short summary line]
[blank line]
[body of message, either a paragraph or bullet points that explains why things have changed]
- Changed python-pip3 because issue with availability to python3-pip which depends on python3 (>= 3.4~) - Changed python-stomp because this lib has a restriction python(<< 2.8) to python3-stomp which depends on python3 (>= 3.3.2-2~) - Changed python-ldap because this lib has a restriction python(<< 2.8) to python3-ldap which depends on python3 (>= 3.3.2-2~)
25eb5c8
to
dfd96e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good.
Related Issue tracking number: 166117
[25eb5c8] :
python-pip3
because issue with availability topython3-pip
which depends on python3 (>= 3.4~)python-stomp
because this lib has a restriction python(<< 2.8) topython3-stomp
which depends on python3 (>= 3.3.2-2~)python-ldap
because this lib has a restriction python(<< 2.8) topython3-ldap
which depends on python3 (>= 3.3.2-2~)