Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the unexpected log.error to use log.exception #314

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Changed the unexpected log.error to use log.exception #314

merged 1 commit into from
Apr 4, 2024

Conversation

Will-Cross1
Copy link
Contributor

@Will-Cross1 Will-Cross1 commented Apr 4, 2024 •
edited
Loading

Resolves #295

this traces back the error to the line in the code

Before:

2024-04-04 15:43:27,858 - ssmsend - INFO - ========================================
2024-04-04 15:43:27,858 - ssmsend - INFO - Starting sending SSM version 3.4.0.
2024-04-04 15:43:27,858 - ssmsend - INFO - Setting up SSM with protocol: AMS
SSM failed to complete successfully.  See log file for details.
2024-04-04 15:43:27,858 - ssmsend - ERROR - Unexpected exception in SSM: msg
2024-04-04 15:43:27,858 - ssmsend - ERROR - Exception type: <class 'ValueError'>
2024-04-04 15:43:27,858 - ssmsend - INFO - SSM has shut down.
2024-04-04 15:43:27,858 - ssmsend - INFO - ========================================

After:

2024-04-04 15:44:13,693 - ssmsend - INFO - ========================================
2024-04-04 15:44:13,693 - ssmsend - INFO - Starting sending SSM version 3.4.0.
2024-04-04 15:44:13,693 - ssmsend - INFO - Setting up SSM with protocol: AMS
SSM failed to complete successfully.  See log file for details.
2024-04-04 15:44:13,693 - ssmsend - ERROR - Unexpected exception in SSM. See traceback below.
Traceback (most recent call last):
  File "~/DCIG/ssm/ssm/agents.py", line 192, in run_sender
    raise ValueError("msg")
ValueError: msg
2024-04-04 15:44:13,693 - ssmsend - INFO - SSM has shut down.
2024-04-04 15:44:13,693 - ssmsend - INFO - ========================================

@Will-Cross1
Resolved issue 295
f832a7a 
changed the unexpected logging to use log.exception

this traces back the error to the line in the code
@Will-Cross1 Will-Cross1 requested a review from a team as a code owner April 4, 2024 13:37
Sae126V
Sae126V approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@Sae126V Sae126V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I see we are trying to capture the traceback information.

@tofu-rocketry
Copy link
Member

I see we are trying to capture the traceback information.

Yeah, there are situations where just the error message itself isn't informative enough.

@tofu-rocketry tofu-rocketry self-assigned this Apr 4, 2024
@tofu-rocketry tofu-rocketry added this to the 3.4.1 milestone Apr 4, 2024
@tofu-rocketry
Copy link
Member

Added an issue for Docker: #315

@tofu-rocketry tofu-rocketry merged commit 6646436 into apel:dev Apr 4, 2024
8 of 10 checks passed
@Will-Cross1 Will-Cross1 deleted the Update-unexpected-exception-295 branch April 9, 2024 09:49
@tofu-rocketry tofu-rocketry mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tofu-rocketry tofu-rocketry tofu-rocketry approved these changes

@Sae126V Sae126V Sae126V approved these changes

Assignees

@tofu-rocketry tofu-rocketry

Labels
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.

Update unexcepted exception handling to log full traceback
3 participants
@Will-Cross1 @tofu-rocketry @Sae126V