Character vs. byte strings fix #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't (yet) want to test against unicode.
Some compatability issues raised in testing with 3.3.0
- Add decoding when sending messages to fix Python 3 issues. - Set both to ascii only as this maintains the behaviour with Python 2 for now while in transition period.
gregcorbett
reviewed
Feb 16, 2024
gregcorbett
approved these changes
Feb 16, 2024
|
I'm very confused on the docker stuff, but Greg's suggestion might work? Mainly just here to log that if it's a PyOpenSSL/crypto interaction of versions, we need to have as late a version of Crypto as possible (3.3.2 with py2 compatibility) and PyOpenSSL (21.0.0) :) |
- Set pyopenssl >=19.1 so that it is compatable with cryptography >=3.3.0 - Revert cryptography requriement to 3.3
tofu-rocketry
force-pushed
the
146-bytes
branch
from
bce101b to
884ab2c
Compare
Pin to 3.3.2, the latest version that's still compatible with Python 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #146
Resolves #209
Note that this is a conservative fix and does not add Unicode support so that the behaviour matches between Python 2 and 3.
Unicode support is tracked in #299.
Tested manually between Python 2 and 3, sending and receiving for each, and using
dirqanddirectorysending.