OpenSSL compatibility fix #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregcorbett
previously requested changes
Oct 3, 2023
|
Confirmed, works with Python 2 |
|
Looks like this needs a rebase. |
tofu-rocketry
requested changes
Oct 9, 2023
RedProkofiev
force-pushed
the
nick-167
branch
2 times, most recently
from
1a0069f to
9c98ae1
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
RedProkofiev
force-pushed
the
nick-167
branch
from
9c98ae1 to
51ea953
Compare
RedProkofiev
force-pushed
the
nick-167
branch
from
7d63e57 to
1f5eea2
Compare
|
Do you think you could add a unit test for the new function? |
|
Yep no problem.
…On Mon, 11 Dec 2023, 17:45 Adrian Coveney, ***@***.***> wrote:
Do you think you could add a unit test for the new function?
—
Reply to this email directly, view it on GitHub
<#272 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU3PGZ2XPGPG6RHQ7B5J4I3YI5BEHAVCNFSM6AAAAAA5PRTRO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQGU3DSNRXHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
tofu-rocketry
force-pushed
the
nick-167
branch
from
969ad2a to
3862a4e
Compare
6 tasks
tofu-rocketry
force-pushed
the
nick-167
branch
3 times, most recently
from
54d3c12 to
b839454
Compare
It's reccomended to add 'yum clean all' to each Docker RUN that does a yum install to keep the image size down.
- Change comment spacing to standard 2 before mark - Change pyopenssl requirement to all lowercase
- Reorder imports to alphabetical order - Change multi-line import to use implicit continuation
tofu-rocketry
force-pushed
the
nick-167
branch
from
b839454 to
86a6ff3
Compare
While it may be a useful function elsewhere in future, it's not currently used outside its own module, so mark is as private. This can allow us to refactor without worrying about anything other than the tests.
tofu-rocketry
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #167
At @jrha 's suggestion, to solve a formatting conflict, this PR adds pyOpenSSL as a dependency and uses it to handle the distinguished name formatting. pyOpenSSL isn't currently used for anything else.