Add sys.exit() to both sender and reciever #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofu-rocketry
requested changes
Sep 18, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Added a flag to both the sender and receiver functions and moved sys.exit() to the end of each. Added an else statement to handle when no exception is encountered, however this is redundant in the receiver function currently due to the while loop but has been left in as a fail safe for future refactoring. |
tofu-rocketry
requested changes
Sep 18, 2023
tofu-rocketry
requested changes
Sep 18, 2023
tofu-rocketry
approved these changes
Sep 18, 2023
Return 1 instead of 0 when failing due to an exception
Added a flag to both sender and reciever to return true when an exception is thrown. Moved sys.exit() to the end of the sender and reveiver functions.
Changed if statement to compact format
tofu-rocketry
force-pushed
the
issue189
branch
from
de24827 to
ecc7835
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #189
Return 1 instead of 0 when failing due to an exception.