Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nick dev brokers #262

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Nick dev brokers #262

merged 2 commits into from
Sep 18, 2023

Conversation

RedProkofiev
Copy link
Contributor

Adding a warning for deprecation of LDAP according to issue #225

@RedProkofiev RedProkofiev requested a review from a team as a code owner September 18, 2023 10:42
@tofu-rocketry tofu-rocketry self-assigned this Sep 18, 2023
Copy link
Member

@tofu-rocketry tofu-rocketry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created a suggested change, but also can you rebase this onto the latest changes on dev to get rid of the duplicate commits from the other PR?

@tofu-rocketry tofu-rocketry added this to the 3.3.1 milestone Sep 18, 2023
RedProkofiev and others added 2 commits September 18, 2023 12:36
Change wording of warning message

Co-authored-by: Adrian Coveney <[email protected]>
@tofu-rocketry tofu-rocketry merged commit f51f6b9 into apel:dev Sep 18, 2023
@RedProkofiev RedProkofiev deleted the nick-dev-brokers branch September 18, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants