Minor timeout changes #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
tofu-rocketry
requested changes
Sep 18, 2023
RedProkofiev
force-pushed
the
nick-dev
branch
from
9b9e0fb to
579da37
Compare
tofu-rocketry
approved these changes
Sep 18, 2023
Add timeout to prevent TCP spinlocks
tofu-rocketry
force-pushed
the
nick-dev
branch
from
579da37 to
5dca2f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #243
Resolves GT-200
Adding timeouts to resolve issue #243 - currently set to 10 second timeouts.
Difficult to consistently unit test for, so manual testing was done by blocking the TCP connection through TCPKill and sending Fallocate-d 512kb messages through and watching the TCP traffic. Timeouts successfully call the underlying requests library, and no longer indefinitely looks for a connection. Tested on a scientific Linux 7 distro running python 3.6.8 and 2.7.5.