-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker build and upload image to GitHub #185
Conversation
51fe326
to
eb65ff2
Compare
eb65ff2
to
c7d17b2
Compare
I've rebased this, for future reference - it's stalled because the container won't build (
|
So the container build is trying to use |
Capping python-ldap atleast allows the container to build, but then it fails uploading to GitHub... progress! |
ah, the "push" docker build was succsessful, but not the "pull_request" version |
So it looks like:
From https://github.com/docker/build-push-action
|
Hmmmm, thinking about this more, we probably don't want to push a container built from a PR to the GitHub registry, though we would want to confirm the container still builds. The action this uses does take |
Hmmmm the container build is now failing because of the Looks like I've opened an issue with the |
For testing-the-container-build purposes, I should be able to pin |
1399dc0
to
0175d6b
Compare
From version 0.5.7 of |
The container now builds, and the push to the GitHub registry works on push events - see https://github.com/gregcorbett/ssm/pkgs/container/ssm/30046106?tag=github_actions_docker. |
- Build on a pull request or on a push of either any branch or a tag matching a proper release of the SSM (not a release candidate or other tagged version) - When it builds a tag, the reultant image will also get pushed to container registry with the `lastest` tag (which is why we only build proper releases of the SSM).
- we don't want a rogue PR creating a container in the registry. GitHub won't let it happen by default anyway.
0175d6b
to
6ba2af4
Compare
Depends on #193, this PR will need to be rebased once that has been merged.Builds a container on a pull request or on a push of either any branch or a tag matching a "proper" release of the SSM (not a release candidate or other tagged version.
When it builds a tag, if the build was done in the main repository, the resultant image will also get pushed to container registry with the
lastest
tag (which is why we only build proper releases of the SSM).