151 DNs file path on command line #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you establish why this affects the |
|
It seemed to create an issue when the DNs were refreshed, it was okay with a relative file path initially but when looping through the get_dns function would throw up an error and could no longer find the file path. |
tofu-rocketry
requested changes
Dec 2, 2021
tofu-rocketry
approved these changes
Jan 17, 2022
tofu-rocketry
force-pushed
the
Issue-151
branch
from
dea855e to
1a730c5
Compare
tofu-rocketry
force-pushed
the
Issue-151
branch
from
1a730c5 to
65d0072
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #151
Allows a relative file path for the DNs file from the command line.