Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor and simplify the config and script template #8902

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Feb 8, 2025

No description provided.

@leon-inf leon-inf added this to the Release 1.0.0 milestone Feb 8, 2025
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 19.29825% with 276 lines in your changes missing coverage. Please review.

Project coverage is 60.06%. Comparing base (e80c30c) to head (408e76f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...s/apps/component/transformer_component_template.go 19.51% 184 Missing and 14 partials ⚠️
pkg/controller/component/synthesize_component.go 13.51% 28 Missing and 4 partials ⚠️
pkg/controller/lifecycle/lfa_replica.go 0.00% 15 Missing ⚠️
pkg/controller/lifecycle/kbagent.go 0.00% 13 Missing ⚠️
pkg/controller/component/kbagent.go 0.00% 5 Missing and 1 partial ⚠️
pkg/controller/lifecycle/lfa_udef.go 0.00% 6 Missing ⚠️
pkg/controller/configuration/template_wrapper.go 0.00% 4 Missing ⚠️
pkg/controller/component/utils.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8902      +/-   ##
==========================================
- Coverage   60.39%   60.06%   -0.33%     
==========================================
  Files         382      385       +3     
  Lines       46448    46778     +330     
==========================================
+ Hits        28050    28097      +47     
- Misses      15697    15972     +275     
- Partials     2701     2709       +8     
Flag Coverage Δ
unittests 60.06% <19.29%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Feb 8, 2025
@leon-inf leon-inf force-pushed the support/config-template branch 4 times, most recently from 408e76f to dae465e Compare February 11, 2025 07:00
@leon-inf leon-inf force-pushed the support/config-template branch from dae465e to 3178cd4 Compare February 11, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant