Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: h-scale opsRequest validation considers replicas and shards limit #8834

Merged
merged 16 commits into from
Mar 5, 2025
Merged

fix: h-scale opsRequest validation considers replicas and shards limit #8834

merged 16 commits into from
Mar 5, 2025

Conversation

yipeng1030
Copy link
Contributor

@yipeng1030 yipeng1030 commented Jan 20, 2025 •
edited
Loading

fix #8737

add a validation rule that a opsRequest considers replicas and shards limit

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Jan 20, 2025
@apecloud-bot apecloud-bot added the pre-approve Fork PR Pre Approve Test label Jan 20, 2025
@yipeng1030 yipeng1030 changed the title bugfix: reject the opsRequest that offlines all the replicas of a component fix: reject the opsRequest that offlines all the replicas of a component Jan 20, 2025
@apecloud-bot apecloud-bot added pre-approve Fork PR Pre Approve Test and removed pre-approve Fork PR Pre Approve Test labels Jan 20, 2025
@yipeng1030 yipeng1030 marked this pull request as ready for review January 20, 2025 14:18
@yipeng1030 yipeng1030 requested review from wangyelei and a team as code owners January 20, 2025 14:18
@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Feb 6, 2025
@apecloud-bot apecloud-bot added pre-approve Fork PR Pre Approve Test and removed pre-approve Fork PR Pre Approve Test labels Feb 6, 2025
@yipeng1030 yipeng1030 marked this pull request as draft February 6, 2025 09:28
@apecloud-bot apecloud-bot added the pre-approve Fork PR Pre Approve Test label Feb 14, 2025
@yipeng1030 yipeng1030 force-pushed the bugfix/improve_scalein_validate branch from 10bb384 to 7b331d2 Compare February 14, 2025 07:44
@apecloud-bot apecloud-bot added pre-approve Fork PR Pre Approve Test and removed pre-approve Fork PR Pre Approve Test labels Feb 14, 2025
@zjx20 zjx20 requested a review from leon-inf February 19, 2025 08:04
@apecloud-bot apecloud-bot added pre-approve Fork PR Pre Approve Test and removed pre-approve Fork PR Pre Approve Test labels Feb 28, 2025
@apecloud-bot apecloud-bot added pre-approve Fork PR Pre Approve Test and removed pre-approve Fork PR Pre Approve Test labels Feb 28, 2025
@apecloud-bot apecloud-bot added pre-approve Fork PR Pre Approve Test and removed pre-approve Fork PR Pre Approve Test labels Mar 3, 2025
@yipeng1030 yipeng1030 force-pushed the bugfix/improve_scalein_validate branch from cb4a9c4 to 9c8dc03 Compare March 4, 2025 07:03
@apecloud-bot apecloud-bot added pre-approve Fork PR Pre Approve Test and removed pre-approve Fork PR Pre Approve Test labels Mar 4, 2025
@yipeng1030 yipeng1030 merged commit fca3a26 into apecloud:main Mar 5, 2025
18 checks passed
@github-actions github-actions bot added this to the Release 1.0.0 milestone Mar 5, 2025
@yipeng1030
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/13666932535

apecloud-bot pushed a commit that referenced this pull request Mar 5, 2025
@yipeng1030
fix: h-scale opsRequest validation considers replicas and shards limit (
f8e4d7e 
#8834)

(cherry picked from commit fca3a26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjx20 zjx20 zjx20 approved these changes

@wangyelei wangyelei wangyelei approved these changes

@JashBook JashBook Awaiting requested review from JashBook

@ahjing99 ahjing99 Awaiting requested review from ahjing99

@linghan-hub linghan-hub Awaiting requested review from linghan-hub

@michelle-0808 michelle-0808 Awaiting requested review from michelle-0808

@shanshanying shanshanying Awaiting requested review from shanshanying

@ldming ldming Awaiting requested review from ldming

@sophon-zt sophon-zt Awaiting requested review from sophon-zt

@Y-Rookie Y-Rookie Awaiting requested review from Y-Rookie

@leon-inf leon-inf Awaiting requested review from leon-inf

Assignees
No one assigned
Labels
pre-approve Fork PR Pre Approve Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
Release 1.0.0
Development

Successfully merging this pull request may close these issues.

[BUG]HscaleOfflineInstances is always in running status when scaleIn component that only has 1 replicas
5 participants
@yipeng1030 @apecloud-bot @zjx20 @wangyelei @leon-inf