-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor parameters partI: add parameters group and api #8582
Conversation
03253e6
to
6297fee
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8582 +/- ##
==========================================
+ Coverage 60.28% 60.47% +0.19%
==========================================
Files 383 389 +6
Lines 46603 47084 +481
==========================================
+ Hits 28093 28476 +383
- Misses 15815 15890 +75
- Partials 2695 2718 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
controllers/parameters/parameterdrivenconfigrender_controller.go
Outdated
Show resolved
Hide resolved
de53cf4
to
2fca37e
Compare
9bca90e
to
4f6ba57
Compare
4f6ba57
to
6e7f44d
Compare
@@ -195,14 +195,14 @@ var _ = BeforeSuite(func() { | |||
}).SetupWithManager(k8sManager, nil) | |||
Expect(err).ToNot(HaveOccurred()) | |||
|
|||
err = (&configuration.ConfigConstraintReconciler{ | |||
err = (¶meters.ConfigConstraintReconciler{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to clean up these controllers and resources from the apps package finally.
…removed injectEnvTo api
bb402b5
to
96c9448
Compare
/approve for test |
/cherry-pick release-1.0-beta |
🤖 says: Error cherry-picking. |
🤖 says: |
No description provided.