Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint fixes #66

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Eslint fixes #66

merged 3 commits into from
Nov 5, 2023

Conversation

rpavlik
Copy link
Contributor

@rpavlik rpavlik commented Aug 31, 2022

Just a few fixes, and I don't think anything was critical, but probably worth having. I didn't commit the config file, I can do so if you like.

@apankrat
Copy link
Owner

Thanks for the PR, Ryan. I'm OK with merging 7a380da, aac9a18, 050de4b and 97bab3f. The rest I'd prefer to skip, because I see little point but to appease eslint. If you are OK with the partial patch, can you redo the PR?

@apankrat apankrat closed this Nov 12, 2022
@apankrat apankrat reopened this Nov 12, 2022
@rpavlik
Copy link
Contributor Author

rpavlik commented Nov 14, 2022

Sure, there you go! 97bab3f dropped out during the rebase because it was literally just undoing part of b990ab2.

@apankrat apankrat merged commit d6384d0 into apankrat:master Nov 5, 2023
@apankrat
Copy link
Owner

apankrat commented Nov 5, 2023

Better late than never. Sorry about the delay.

@rpavlik rpavlik deleted the eslint branch November 6, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpavlik @apankrat