Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #985: do not skolemize let-definitions that are used as values #989

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

konnov
Copy link
Collaborator

@konnov konnov commented Sep 16, 2021

Closes #985: do not skolemize let-definitions that are used as values. The solution to introduce two versions of let-definitions: one that is skolemized and another that is not skolemized. The downside is that we have redundant definitions. We will have to introduce another pass that removes unused let-definitions.

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entry added to UNRELEASED.md for any new functionality

@konnov konnov requested review from shonfeder and Kukovec September 16, 2021 11:59
Copy link
Collaborator

@Kukovec Kukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@konnov konnov merged commit 2b554b6 into unstable Sep 16, 2021
@konnov konnov deleted the igor/bug985 branch September 16, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unsound skolemization
2 participants