Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Standardize operator names in the IR #634

Closed
konnov opened this issue Mar 10, 2021 · 1 comment · Fixed by #726
Closed

[FEATURE] Standardize operator names in the IR #634

konnov opened this issue Mar 10, 2021 · 1 comment · Fixed by #726
Assignees
@konnov @Kukovec
Labels
refactoring
Milestone
April iteration

Comments

@konnov
Copy link
Collaborator

konnov commented Mar 10, 2021

Related to #610. We have to go over all operator names and change them to concise alphanumeric names. Some names are pretty ad-hoc in the current version like _.._, {...}, and _(). Since the operators names are used in the JSON format, we have to bring some order there.
@konnov konnov added this to the March iteration milestone Mar 10, 2021
@konnov konnov mentioned this issue Mar 25, 2021
Merged
@konnov konnov self-assigned this Apr 9, 2021
@konnov
Copy link
Collaborator Author

konnov commented Apr 9, 2021

We should fast track it for an internal project

konnov added a commit that referenced this issue Apr 11, 2021
@konnov
closes #634: cleaning up the operator names
6560498
@konnov konnov mentioned this issue Apr 11, 2021
Merged
4 tasks
konnov added a commit that referenced this issue Apr 13, 2021
@konnov
Cleaning up the operator names (#726)
9587968 
* closes #634: cleaning up the operator names

* using qualified names in the test

* add changelog entry

* Update tlair/src/main/scala/at/forsyte/apalache/tla/lir/oper/TlaFunOper.scala

Co-authored-by: Shon Feder <[email protected]>

* Update tlair/src/main/scala/at/forsyte/apalache/tla/lir/oper/TlaTempOper.scala

Co-authored-by: Shon Feder <[email protected]>

* fix formatting

Co-authored-by: Shon Feder <[email protected]>
This was referenced Apr 19, 2021
Merged
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konnov konnov

@Kukovec Kukovec

Labels
refactoring
Projects
None yet
Milestone
April iteration
Development

Successfully merging a pull request may close this issue.

Cleaning up the operator names apalache-mc/apalache
2 participants
@konnov @Kukovec