Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2632] Data race in IncAllocatedResource #870

Closed
wants to merge 1 commit into from

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented May 17, 2024

What is this PR for?

We have unlocked access to Queue.allocatedResource as a result of YUNIKORN-2548.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2632

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko pbacsko self-assigned this May 17, 2024
@pbacsko pbacsko requested review from wilfred-s and craigcondit and removed request for wilfred-s May 17, 2024 14:19
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 77.10%. Comparing base (9d7fddf) to head (042304b).

Files Patch % Lines
pkg/scheduler/objects/queue.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #870   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files          97       97           
  Lines       11989    11989           
=======================================
  Hits         9244     9244           
  Misses       2414     2414           
  Partials      331      331           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@pbacsko pbacsko closed this in 63a91f6 May 17, 2024
pbacsko added a commit that referenced this pull request May 17, 2024
Closes: #870

Signed-off-by: Peter Bacsko <[email protected]>
(cherry picked from commit 63a91f6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants