[YUNIKORN-2590] Handler tests should check for nil request on create

[ryankert01]

What is this PR for?

In the handler_test.go file we have an anti pattern showing a large number (40+) warnings in an IDE:

'req' might have 'nil' or other unexpected value as its corresponding error variable might be not 'nil'

The warning are due to the fact that we have the following pattern:

req, err = http.NewRequest("GET", "path", strings.NewReader(""))
req = req.WithContext(context.WithValue(req.Context(), httprouter.ParamsKey, httprouter.Params{}))

There is no error assertion after the request creation. We should add a simple assert.NilError(t, err, "HTTP request create failed") inserted between creating and using the request.

What type of PR is it?

• - Bug Fix
• - Improvement
• - Feature
• - Documentation
• - Hot Fix
• - Refactoring

Todos

n/a

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2590

How should this be tested?

Github CI

Screenshots (if appropriate)

Questions:

• - The licenses files need update.
• - There is breaking changes for older versions.
• - It needs documentation.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.07%. Comparing base (aab9eb7) to head (59c62e5).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
- Coverage   77.08%   77.07%   -0.02%     
==========================================
  Files          97       97              
  Lines       11989    11989              
==========================================
- Hits         9242     9240       -2     
- Misses       2415     2416       +1     
- Partials      332      333       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chia7712]

LGTM