[Bugfix][ROCm] Handle tvm_thread_invariant in ROCm backend #16403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR apache#16345 introduced a TIR intrinsic `tvm_thread_invariant` as a no-op intrinsic that indicates that a condition is an invariant across threads. It is a necessary change to support MoE group GEMM operations. However, we noticed that the LLVM-ROCm backend has been broken since then because this no-op intrinsic hasn't been properly handled in this particular backend. This PR fixes this behavior by checking this no-op in the LLVM backend.
|
Superseded by #16404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #16345 introduced a TIR intrinsic
tvm_thread_invariantas a no-op intrinsic that indicates that a condition is an invariant across threads. It is a necessary change to support MoE group GEMM operations.However, we noticed that the LLVM-ROCm backend has been broken since then because this no-op intrinsic hasn't been properly handled in this particular backend. This PR fixes this behavior by checking this no-op in the LLVM backend.
CC: @spectrometerHBH @yzhliu @tqchen