[Disco] Add loader for presharded params. #15676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csullivan
force-pushed
the
presharded_loader
branch
from
614eb26 to
d00aa2b
Compare
csullivan
force-pushed
the
presharded_loader
branch
from
d00aa2b to
992f66d
Compare
Lunderberg
reviewed
Sep 21, 2023
| int worker_id = worker->worker_id; | ||
| int num_shards = worker->num_workers; | ||
| Device device = worker->default_device; | ||
| size_t index = weight_index * num_shards + worker_id; |
There was a problem hiding this comment.
Does this line line imply that a sharded parameter set contains only sharded parameters? I don't think that assumption is true for our use case. (e.g. Sharded weights/bias for matmul, but unsharded vocab embedding)
|
In discussion with @csullivan , this PR is superseded by #15957. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support loading params that are already sharded via a rewrite transform and the use of LiftTransformParams.