Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix][Relay] Fix softplus in paddlepaddle frontend #14845

Merged
merged 3 commits into from
May 15, 2023

Conversation

jikechao
Copy link
Contributor

@jikechao jikechao commented May 13, 2023

This PR fixed a similar bug with #14821 in the PaddlePaddle frontend.

For the PaddlePaddle documentation, when input * beta > threshold, Softplus(x) = x.
image

TVM miss this special case handling. It would cause wrong inference results.

A patch and a Test case that can trigger this bug are submitted in this PR.

cc @Hzfengsy @echuraev @jiangjiajun

@tvm-bot
Copy link
Collaborator

tvm-bot commented May 13, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@github-actions github-actions bot requested review from Hzfengsy and echuraev May 13, 2023 11:23
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@echuraev echuraev merged commit 602133e into apache:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants