-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Adreno] Add documentation for Adreno deployment #13393
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
9bf1929
to
bb8696d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the images we prefer to keep binary files outside of the repo for readability / size reasons, can you instead make a PR to add them to https://github.com/tlc-pack/web-data and tag me in it? Once that's done you can link to them in rst e.g.
just saw your comment @echuraev, we can merge the PR to tlc-pack/web-data
first then use that on this PR to make sure it's all good, then merge this one
|
||
For the complete step-py-step process of compiling and deploying models on | ||
Adreno, including selection of precision, running the inference of the | ||
model, getting the predictions, and measuring the performance please refer to this tutorial: `How To Deploy model on Adreno <https://tvm.apache.org/docs/how_to/deploy_models/deploy_model_on_adreno.html>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably the link can be relative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find references for creating relative links in other apache documents.
@driazati what do you think about that? Should we somehow make relative links to the other docs?
docs/how_to/deploy/adreno.rst
Outdated
* Operations which can be converted if they follow by converted cluster | ||
* Operations never be converted to the float16 data type | ||
This list is defined in the ToMixedPrecision implementation here | ||
`relay/transform/mixed_precision.py <https://github.com/apache/tvm/blob/main/python/tvm/relay/transform/mixed_precision.py#L34>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably it would be better to have relative links. Not sure if it will work with specifying line number. But anyway, line number might be not actual after adding something to this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't make a relative link to other site.
hey @dsbarinov1 just a note on the CI failures, you'll probably need to rebase your changes on the latest |
23a78ab
to
28b1562
Compare
Purpose: assist TVM users compile and deploy on Adreno by expanding our documentation and providing sample scripts in TVM. Information about PR: The present PR consists globally of 3 parts. The first part is an introductory article on compilation and deployment of neural networks on Adreno, covering such topics as: «Build TVM for Android/Adreno», «Advantages of textures» and «Differences in compilation and deployment of models for Adreno devices». The second part is a straightforward example script for compiling and inferring models at different precisions for Adreno devices. The third part is auxiliary files, images, etc.
…in docs to work without this extension
962b89a
to
81a60ce
Compare
docs/how_to/deploy/adreno.rst
Outdated
Alternatively, to build a TVM via docker using OpenCL-Headers and set-up | ||
with Android TVM RPC, refer to this guide: `Deploy the Pretrained Model on Android <https://tvm.apache.org/docs/how_to/deploy_models/deploy_model_on_android.html>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phrase about OpenCL-Headers
is not actual now. OpenCL Headers are not necessary for building TVM now and this documentation also was updated in this commit: 2bb3382
Alternatively, to build a TVM via docker using OpenCL-Headers and set-up | |
with Android TVM RPC, refer to this guide: `Deploy the Pretrained Model on Android <https://tvm.apache.org/docs/how_to/deploy_models/deploy_model_on_android.html>`_. | |
Since there are many required packages for Android, you can use the official Docker Image to build TVM. For more information refer to this guide: `Deploy the Pretrained Model on Android <https://tvm.apache.org/docs/how_to/deploy_models/deploy_model_on_android.html>`_. |
Seems like PR #13073 broke these instructions, and now additionally requires specifying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
6836a6f
to
98ee8b5
Compare
@echuraev You should be able to merge now. |
Purpose:
assist TVM users compile and deploy on Adreno by expanding our documentation and providing sample scripts in TVM.
Information about PR:
The present PR consists globally of 3 parts.
The first part is an introductory article on compilation and deployment of neural networks on Adreno, covering such topics as: «Build TVM for Android/Adreno», «Advantages of textures» and «Differences in compilation and deployment of models for Adreno devices».
The second part is a straightforward example script for compiling and inferring models at different precisions for Adreno devices.
The third part is auxiliary files, images, etc.