Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run cpplint in quiet mode #10292

Merged
merged 1 commit into from
May 2, 2022
Merged

Run cpplint in quiet mode #10292

merged 1 commit into from
May 2, 2022

Conversation

areusch
Copy link
Contributor

@areusch areusch commented Feb 17, 2022

Removes lots of

Done processing ...

spam from cpplint logs.

cc @driazati

@areusch
Copy link
Contributor Author

areusch commented Feb 17, 2022

also cc @tqchen due to related dmlc-core change.

driazati
driazati approved these changes Feb 17, 2022
View reviewed changes
tests/lint/cpplint.sh Show resolved Hide resolved
@areusch areusch force-pushed the quiet-cpplint branch 2 times, most recently from 7f2b524 to 0580c5b Compare February 21, 2022 06:01
@areusch areusch force-pushed the quiet-cpplint branch 4 times, most recently from f65f353 to 0543115 Compare March 7, 2022 22:09
@areusch
Copy link
Contributor Author

areusch commented Mar 14, 2022

:/ i think maybe the rust build is busted when dlpack is updated.

@github-actions
Copy link
Contributor

It has been a while since this PR was updated, @tqchen @driazati @driazati please leave a review or address the outstanding comments

1 similar comment
@github-actions
Copy link
Contributor

It has been a while since this PR was updated, @tqchen @driazati @driazati please leave a review or address the outstanding comments

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

It has been a while since this PR was updated, @tqchen @driazati please leave a review or address the outstanding comments. @areusch if this PR is still a work in progress, please convert it to a draft until it is ready for review.

@github-actions
Copy link
Contributor

It has been a while since this PR was updated, @tqchen @driazati please leave a review or address the outstanding comments. @areusch if this PR is still a work in progress, please convert it to a draft until it is ready for review.

@areusch
Copy link
Contributor Author

areusch commented Apr 21, 2022

blocked on dmlc/dmlc-core#658 (review)

@github-actions
Copy link
Contributor

It has been a while since this PR was updated, @driazati @tqchen please leave a review or address the outstanding comments. @areusch if this PR is still a work in progress, please convert it to a draft until it is ready for review.

@areusch
Copy link
Contributor Author

areusch commented Apr 29, 2022

busted copy constructor was reverted for now, retrying this one

@areusch areusch merged commit b878dcf into apache:main May 2, 2022
shtinsa pushed a commit to Deelvin/tvm that referenced this pull request May 17, 2022
@areusch
Run cpplint in quiet mode. (apache#10292)
ebd4304
SebastianBoblest pushed a commit to SebastianBoblest/tvm that referenced this pull request May 27, 2022
@areusch
Run cpplint in quiet mode. (apache#10292)
ac3db69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

@driazati driazati driazati approved these changes

@comaniac comaniac Awaiting requested review from comaniac

@junrushao junrushao Awaiting requested review from junrushao

@jroesch jroesch Awaiting requested review from jroesch

@yzhliu yzhliu Awaiting requested review from yzhliu

@merrymercy merrymercy Awaiting requested review from merrymercy

@icemelon icemelon Awaiting requested review from icemelon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@areusch @tqchen @driazati