Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed anycast functionality from traffic control #7877

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

rimashah25
Copy link
Contributor

Reverting changes in #7302


Which Traffic Control components are affected by this PR?

  • Traffic Monitor

What is the best way to verify this PR?

TM should work as expected.

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

* removed anycast functionality from traffic control

* added changelog for pr

* corrected formatting in traffic_monitor/datareq/datareq.go

---------

Co-authored-by: serDrem <[email protected]>
@rimashah25 rimashah25 requested a review from zrhoffman December 4, 2023 19:49
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (fa231d7) 65.64% compared to head (0248c37) 31.83%.

❗ Current head 0248c37 differs from pull request most recent head 915e6ad. Consider uploading reports for the commit 915e6ad to get more accurate results

Files Patch % Lines
traffic_monitor/datareq/crstate.go 0.00% 11 Missing ⚠️
traffic_monitor/health/cache.go 33.33% 4 Missing ⚠️
traffic_monitor/datareq/datareq.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #7877       +/-   ##
=============================================
- Coverage     65.64%   31.83%   -33.81%     
  Complexity       98       98               
=============================================
  Files           323      719      +396     
  Lines         12836    82714    +69878     
  Branches        970      970               
=============================================
+ Hits           8426    26335    +17909     
- Misses         4050    54221    +50171     
- Partials        360     2158     +1798     
Flag Coverage Δ
golib_unit 53.86% <ø> (?)
grove_unit 12.02% <ø> (?)
t3c_unit 5.88% <ø> (?)
traffic_monitor_unit 25.47% <15.78%> (?)
traffic_ops_unit 21.68% <ø> (?)
traffic_portal_v2 74.30% <ø> (-0.06%) ⬇️
traffic_stats_unit 10.78% <ø> (?)
unit_tests 29.15% <15.78%> (-45.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about the changelog, otherwise it looks good. Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
@zrhoffman zrhoffman merged commit 3710add into apache:master Dec 4, 2023
29 of 30 checks passed
@rimashah25 rimashah25 deleted the remove-anycast-functionality branch December 4, 2023 20:14
rimashah25 added a commit that referenced this pull request Jan 3, 2024
* Removed anycast functionality from traffic control (#62)

* removed anycast functionality from traffic control

* added changelog for pr

* corrected formatting in traffic_monitor/datareq/datareq.go

---------

Co-authored-by: serDrem <[email protected]>

* Updated changelog

---------

Co-authored-by: Dremin, Sergey (Principal SRE, CDN EngOps) <[email protected]>
Co-authored-by: serDrem <[email protected]>
(cherry picked from commit 3710add)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants