-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t3c remove stale git lock file #7346
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7346 +/- ##
============================================
- Coverage 25.07% 25.06% -0.01%
Complexity 98 98
============================================
Files 593 593
Lines 73616 73644 +28
Branches 90 90
============================================
+ Hits 18459 18460 +1
- Misses 53406 53433 +27
Partials 1751 1751
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good to me.
When using git to track changes in etc/trafficserver sometimes the lock file isn't cleared and git will stop updating. This PR will cause t3c-apply to look for a lock file that is more than 5 min old and remove if it exists.
Which Traffic Control components are affected by this PR?
t3c
, formerly ORT)What is the best way to verify this PR?
The best way to verify and to create an
index.lock
file in/opt/trafficserver/etc/trafficserver/.git/
and tailreval.log
andsyncds.log
when the file is 5 minutes old it will be cleared.If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist