-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integer overflow for czCount #7272
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7272 +/- ##
=========================================
Coverage 28.29% 28.29%
Complexity 98 98
=========================================
Files 617 617
Lines 69650 69650
Branches 90 90
=========================================
Hits 19704 19704
Misses 48126 48126
Partials 1820 1820
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Haven't tested it (new test case) on local.
...er/core/src/main/java/org/apache/traffic_control/traffic_router/core/router/StatTracker.java
Outdated
Show resolved
Hide resolved
...ore/src/test/java/org/apache/traffic_control/traffic_router/core/router/StatTrackerTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR closes #7252
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Follow the steps in the linked GH issue
Make sure all the tests pass
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist