Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integer overflow for czCount #7272

Merged
merged 4 commits into from
Jan 9, 2023

Conversation

srijeet0406
Copy link
Contributor

This PR closes #7252


Which Traffic Control components are affected by this PR?

  • Traffic Router

What is the best way to verify this PR?

Follow the steps in the linked GH issue
Make sure all the tests pass

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #7272 (41ecfa7) into master (47098fb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #7272   +/-   ##
=========================================
  Coverage     28.29%   28.29%           
  Complexity       98       98           
=========================================
  Files           617      617           
  Lines         69650    69650           
  Branches         90       90           
=========================================
  Hits          19704    19704           
  Misses        48126    48126           
  Partials       1820     1820           
Flag Coverage Δ
traffic_router_unit 29.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Haven't tested it (new test case) on local.

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zrhoffman zrhoffman merged commit f489865 into apache:master Jan 9, 2023
@asf-ci asf-ci mentioned this pull request Feb 1, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traffic Router (TR) czCount integer overflow in Traffic Ops (TO)
3 participants