Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T3c bad cert check #7153

Merged
merged 3 commits into from
Nov 2, 2022
Merged

T3c bad cert check #7153

merged 3 commits into from
Nov 2, 2022

Conversation

traeak
Copy link
Contributor

@traeak traeak commented Oct 24, 2022 •
edited
Loading

t3c will panic and crash when a pem.Decode fails for a base64 decoded cert. This adds extra logic to identify and skip a cert that fails this way.

Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)

What is the best way to verify this PR?

Find some way to corrupt a delivery service SSL keys cert. Look for ERROR with invalid cert message.

If this is a bugfix, which Traffic Control versions contained the bug?

7.1.0

PR submission checklist

@traeak traeak marked this pull request as ready for review October 24, 2022 18:35
@traeak traeak changed the title T3c bad cert T3c bad cert check Oct 24, 2022
@zrhoffman zrhoffman added bug something isn't working as intended SSL support for/problems with SSL features cache-config Cache config generation labels Oct 24, 2022
jpappa200
jpappa200 approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@jpappa200 jpappa200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocket8888 ocket8888 added low impact affects only a small portion of a CDN, and cannot itself break one low difficulty the estimated level of effort to resolve this issue is low labels Oct 26, 2022
rob05c
rob05c approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@rob05c rob05c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Code looks straightforward, definitely a good check to add.

@rob05c rob05c merged commit f8564f8 into apache:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rob05c rob05c rob05c approved these changes

@jpappa200 jpappa200 jpappa200 approved these changes

Assignees
No one assigned
Labels
bug something isn't working as intended cache-config Cache config generation low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one SSL support for/problems with SSL features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@traeak @rob05c @jpappa200 @ocket8888 @zrhoffman