Apply trivial formatting improvements to kotlin #2842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies trivial formatting requirements for ktfmt 0.13.0 from abandoned PR apache#2837, but does not bump ktfmt to 0.13.0, due to bugs in that version. These formatting improvements should be suitable for the current 0.12.0 version of ktfmt, but will avoid needing to re-apply these changes when ktfmt is eventually updated.
|
This isn't worth it. I thought maybe code formatted this way would be okay with 0.12.0, but no, 0.12.0 and 0.13.0 formattings are mutually exclusive. The code will just have to be reformatted if/when the ktfmt plugin gets updated, which right now it can't be because of the bug. So, the current code is fine, and I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies trivial formatting requirements for ktfmt 0.13.0 from abandoned PR #2837, but does not bump ktfmt to 0.13.0, due to bugs in that version. These formatting improvements should be suitable for the current 0.12.0 version of ktfmt, but will avoid needing to re-apply these changes when ktfmt is eventually updated.