slice/explore header #996
Merged
slice/explore header #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should work for the visualizing flow from the sql editor as well. |
|
Good idea @ascott, another way how it could be implemented - we could make the default slice name by the correspondent datasource. |
|
@bkyryliuk i think it's a good idea on visualize to make the default slice name the data source name. this will cover the case when a slice hasn't been created yet and someone is just exploring a table/datasource. |
| </h2> | ||
| {% endif %} | ||
| {% else %} | ||
| <h2>{{viz.datasource.table_name}}</h2> |
There was a problem hiding this comment.
style guide for jinja says leave room as in {{ foo }}
|
|
|
good suggestion @mistercrunch. made that change.
|
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a table is being explored, and not a slice, use the datasource name rather than nothing.
@mistercrunch @bkyryliuk thoughts on this?