Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not delete schema permission on the table deletion #8768

Merged
merged 1 commit into from
Dec 8, 2019

Conversation

bkyryliuk
Copy link
Member

@bkyryliuk bkyryliuk commented Dec 5, 2019

CATEGORY

Choose one

  • Bug Fix

SUMMARY

Previously in the code on the table deletion would also delete a relevant schema permission. However there might me other tables existing that share the same schema permission. It causes users loosing access to the tables for the whole schema.

This PR just removes the code that was deleting schema permission on every table delete.

REVIEWERS

@dpgaspar
@willbarrett

@codecov-io
Copy link

Codecov Report

Merging #8768 into master will decrease coverage by 6.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8768      +/-   ##
==========================================
- Coverage   72.07%   65.85%   -6.22%     
==========================================
  Files         123      482     +359     
  Lines       12844    24149   +11305     
  Branches        0     2770    +2770     
==========================================
+ Hits         9257    15903    +6646     
- Misses       3587     8068    +4481     
- Partials        0      178     +178
Impacted Files Coverage Δ
superset/views/base.py 74.74% <ø> (+2.24%) ⬆️
superset/assets/src/components/Checkbox.jsx 100% <0%> (ø)
.../assets/src/dashboard/reducers/dashboardFilters.js 88.46% <0%> (ø)
...ets/src/dashboard/components/dnd/DragDroppable.jsx 94.59% <0%> (ø)
superset/assets/src/components/EditableTitle.jsx 80.28% <0%> (ø)
...src/explore/components/controls/VizTypeControl.jsx 76.92% <0%> (ø)
...t/assets/src/components/InfoTooltipWithTrigger.jsx 38.46% <0%> (ø)
.../src/dashboard/components/UndoRedoKeylisteners.jsx 9.52% <0%> (ø)
...ts/src/explore/components/ExploreActionButtons.jsx 100% <0%> (ø)
.../src/dashboard/components/FilterTooltipWrapper.jsx 100% <0%> (ø)
... and 350 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665e947...9f19559. Read the comment docs.

@bkyryliuk bkyryliuk changed the title [WIP] Do not delete schema permission on the table deletion Do not delete schema permission on the table deletion Dec 5, 2019
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistercrunch mistercrunch merged commit c3f15b9 into apache:master Dec 8, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants