Re-enable pylint for superset/utils folder #8766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8766 +/- ##
==========================================
- Coverage 65.83% 65.83% -0.01%
==========================================
Files 482 482
Lines 24155 24153 -2
Branches 2770 2770
==========================================
- Hits 15903 15901 -2
Misses 8074 8074
Partials 178 178
Continue to review full report at Codecov.
|
dpgaspar
requested changes
Dec 6, 2019
| @@ -30,7 +29,7 @@ def import_datasource( | |||
| superset instances. Audit metadata isn't copies over. | |||
| """ | |||
| make_transient(i_datasource) | |||
| logging.info("Started import of the datasource: {}".format(i_datasource.to_json())) | |||
| logging.info("Started import of the datasource: %s", i_datasource.to_json()) | |||
There was a problem hiding this comment.
not according to pylint.
There was a problem hiding this comment.
fstrings and .format are not recommended for logging statements because they make you pay the cost of formatting the string regardless of logging level. Not that it's expensive, but it's best practice to use the format above for that reason
mistercrunch
approved these changes
Dec 6, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Re-enables pylint for a few files in the superset/utils folder.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@john-bodley @dpgaspar @mistercrunch